Hi, On Thu, 29 Feb 2024 14:49:16 +0000, Mark Brown wrote: > On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote: > > On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote: > > > > + /* Number of interrupts supported by each voltage source */ > > > + interrupt_cnt = (tps->chip_id == TPS6594) ? > > > + ARRAY_SIZE(tps6594_buck1_irq_types) : > > > + ARRAY_SIZE(tps65224_buck1_irq_types); > > > The comment is not adding anything, the name is clear and ARRAY_SIZE is > > quite explicit. > > Also please don't abuse the ternery operator like this, write normal > conditionals or for a case like this where we may get more options in > future use switch statements. Got it! will fix it in the next version. Regards, Bhargav
