Re: [PATCH v1 2/2] ASoC: codecs: ES8326: change support for ES8326

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 06, 2024 at 12:36:50PM +0000, Mark Brown wrote:
> On Wed, Mar 06, 2024 at 09:34:14AM +0800, Zhang Yi wrote:
> > Removed mic1-src and mic2-src. and changed default value
> > of interrupt-clk
> 
> We could do with a better changelog here.
> 
> > -  everest,mic1-src:
> > -    $ref: /schemas/types.yaml#/definitions/uint8
> > -    description:
> > -      the value of reg 2A when headset plugged.
> > -    minimum: 0x00
> > -    maximum: 0x77
> > -    default: 0x22
> > -
> > -  everest,mic2-src:
> > -    $ref: /schemas/types.yaml#/definitions/uint8
> > -    description:
> > -      the value of reg 2A when headset unplugged.
> > -    minimum: 0x00
> > -    maximum: 0x77
> > -    default: 0x44
> 
> This will make any DTs using the properties instantly buggy.  I believe
> there's a way of marking properties as deprecated, you should use that
> instead.  Or we could just leave the properties there and ignore them at
> runtime.

'deprecated: true' is the way.

Rob




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux