On Wed, 6 Mar 2024 at 17:36, Chukun Pan <amadeus@xxxxxxxxxx> wrote: > > Hi, Dmitry > > How is it "some"? You are enabling this opp for all IPQ6000 SoC instances. > > This is not the case, please see `opp-supported-hw = <0x4>;`. > Also: https://github.com/torvalds/linux/blob/master/drivers/cpufreq/qcom-cpufreq-nvmem.c#L345 > This 1.2GHz Frequency only takes effect when BIT(2) exists. > For fused 1.5GHz devices, the 1.2GHz frequency will not appear. > I have tested this patch on both fused 1.2GHz and 1.5GHz devices. I did before writing the comment. You have the only IPQ6000 case, it sets drv->versions = IPQ6000_VERSION = BIT(2) = 0x4. So, as I said, you are enabling this for all IPQ6000 SoC versions, unless I miss something. -- With best wishes Dmitry
