On 3/6/24 09:24, Catalin Popescu wrote:
Add support for PHY WOL capability into dwmac-imx MAC driver. This is required to enable WOL feature on a platform where MAC WOL capability is not sufficient and WOL capability built into the PHY is actually needed. Signed-off-by: Catalin Popescu <catalin.popescu@xxxxxxxxxxxxxxxxxxxx>
Nope, this is not about how to do this. You use a Device Tree property as a policy rather than properly describe your systems capabilities.
What sort of Wake-on-LAN do you want to be done by the PHY exactly? Does the PHY have packet matching capabilities, or do you want to wake-up from a PHY event like link up/down/any interrupt?
If the former, then you would need to interrogate the PHY driver via phy_ethtool_get_wol() to figure out what Wake-on-LAN modes it is capable of supporting and then make a decision whether to prioritize Wake-on-LAN from the PHY or the MAC, or maybe only the PHY can actually wake-up the system in your case.
If the latter, then you need to add support for WAKE_PHY to the stmmac driver. pw-bot: cr -- Florian
