Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> writes: > Different Qualcomm platforms using WCN3990 WiFI chip use SoC-specific > firmware versions with different features. For example firmware for > SDM845 doesn't use single-chan-info-per-channel feature, while firmware > for QRB2210 / QRB4210 requires that feature. Allow board DT files to > override the subdir of the fw dir used to lookup the firmware-N.bin file > decribing corresponding WiFi firmware. > > For example: > > - ath10k/WCN3990/hw1.0/wlanmdsp.mbn, > ath10k/WCN3990/hw1.0/firmware-5.bin: main firmware files, used by default > > - ath10k/WCN3990/hw1.0/qcm2290/wlanmdsp.mbn, > ath10k/WCN3990/hw1.0/qcm2290/firmware-5.bin: SoC specific firmware > with different signature and feature bits Thanks, this looks good now. > Note, while board files lookup uses the same function and thus it is > possible to provide board-specific board-2.bin files, this is not > required in 99% of cases as board-2.bin already contains a way to > provide board-specific data with finer granularity than DT overrides. After thinking more about this I agree, we want to have just one board-2.bin file for WCN3990 as it makes easier to share board files across all variants. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches