Hi Paul, On Wed, Feb 28, 2024 at 3:30 PM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote: > > Dear Ban, > > > Thank you for your patch. > > > Am 27.02.24 um 01:56 schrieb baneric926@xxxxxxxxx: > > From: Ban Feng <kcfeng0@xxxxxxxxxxx> > > > > Adding bindings for the Nuvoton NCT7363Y Fan Controller > > s/Adding/Add/ or even Document bindings … ok, fix in v5 > > Do you have an URL to the datasheet? I'll add "Datasheet: Available from Nuvoton upon request" per Guenter suggested in v5. > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Ban Feng <kcfeng0@xxxxxxxxxxx> > > --- > > .../bindings/hwmon/nuvoton,nct7363.yaml | 63 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > new file mode 100644 > > index 000000000000..1a9d9a5d614e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > @@ -0,0 +1,63 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NCT7363Y Hardware Monitoring IC > > + > > +maintainers: > > + - Ban Feng <kcfeng0@xxxxxxxxxxx> > > + > > +description: | > > + The NCT7363Y is a Fan controller which provides up to 16 independent > > lowecase: fan controller? ok, fix in v5 > > > + FAN input monitors, and up to 16 independent PWM output with SMBus interface. > > output*s*? ok, fix in v5 Thanks, Ban > > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,nct7363 > > + > > + reg: > > + maxItems: 1 > > + > > + "#pwm-cells": > > + const: 2 > > + > > +patternProperties: > > + "^fan-[0-9]+$": > > + $ref: fan-common.yaml# > > + unevaluatedProperties: false > > + required: > > + - pwms > > + - tach-ch > > + > > +required: > > + - compatible > > + - reg > > + - "#pwm-cells" > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + hwmon: hwmon@22 { > > + compatible = "nuvoton,nct7363"; > > + reg = <0x22>; > > + #pwm-cells = <2>; > > + > > + fan-0 { > > + pwms = <&hwmon 0 50000>; > > + tach-ch = /bits/ 8 <0x00>; > > + }; > > + fan-1 { > > + pwms = <&hwmon 1 50000>; > > + tach-ch = /bits/ 8 <0x01>; > > + }; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2ecaaec6a6bf..7b1efefed7c4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -15084,6 +15084,12 @@ S: Maintained > > F: Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml > > F: drivers/hwmon/nct6775-i2c.c > > > > +NCT7363 HARDWARE MONITOR DRIVER > > +M: Ban Feng <kcfeng0@xxxxxxxxxxx> > > +L: linux-hwmon@xxxxxxxxxxxxxxx > > +S: Maintained > > +F: Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > + > > NETDEVSIM > > M: Jakub Kicinski <kuba@xxxxxxxxxx> > > S: Maintained > > Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx> > > > Kind regards, > > Paul
