Hi Daniel, On 3/3/24 03:37, Daniel Golle wrote: >> +/* u32 (DWORD) component macros */ >> +#define LOWORD(d) ((u16)(u32)(d)) >> +#define HIWORD(d) ((u16)(((u32)(d)) >> 16)) > > You could use the existing macros in wordpart.h instead. I can already change it to this: /* Replace with #include <linux/wordpart.h> when available */ #define lower_16_bits(n) ((u16)((n) & 0xffff)) #define upper_16_bits(n) ((u16)((n) >> 16)) > Suggestion: > /* BUG in PHY firmware: EN8811H_2P5G_LPA_2P5G does not get set. > > Or just skip that line entirely as the following two lines already > perfectly explain the situation. I'll just remove this line then. Best regards, Eric Woudstra
