Dmitry, Dmitry Torokhov, 2024-03-03T12:39:46-08:00: > On Sun, Mar 03, 2024 at 11:04:25AM +0100, Karel Balej wrote: > > From: Karel Balej <balejk@xxxxxxxxx> > > > > Marvell 88PM886 PMIC provides onkey among other things. Add client > > driver to handle it. The driver currently only provides a basic support > > omitting additional functions found in the vendor version, such as long > > onkey and GPIO integration. > > > > Signed-off-by: Karel Balej <balejk@xxxxxxxxx> > > --- > > > > Notes: > > RFC v3: > > - Drop wakeup-source. > > RFC v2: > > - Address Dmitry's feedback: > > - Sort includes alphabetically. > > - Drop onkey->irq. > > - ret -> err in irq_handler and no initialization. > > - Break long lines and other formatting. > > - Do not clobber platform_get_irq error. > > - Do not set device parent manually. > > - Use input_set_capability. > > - Use the wakeup-source DT property. > > - Drop of_match_table. > > I only said that you should not be using of_match_ptr(), but you still > need to have of_match_table set and have MODULE_DEVICE_TABLE() for the > proper module loading support. I removed of_match_table because I no longer need compatible for this -- there are no device tree properties and the driver is being instantiated by the MFD driver. Is the MODULE_DEVICE_TABLE() entry needed for the driver to probe when compiled as module? If that is the case, given what I write above, am I correct that MODULE_DEVICE_TABLE(platform,...) would be the right thing to use here? Thank you, kind regards, K. B.
