On Mon, Mar 04, 2024 at 06:07:54PM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 4, 2024 at 4:47 PM Uwe Kleine-König <ukleinek@xxxxxxxxxx> wrote:
> >
> > While it requires to have the right phy driver loaded (i.e. motorcomm)
> > to make the phy asserting the right delays, this is generally the
> > preferred way to define the MAC <-> PHY connection.
> >
> > Signed-off-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx>
> > ---
> > Hello,
> >
> > Andrew already pointed out when I posted the patch introducing the gmac0 node
> > that rgmii-id would be the preferred way to setup things. Back then this didn't
> > happen because this change broke reception of network packets. However this
> > only happend because I didn't have the right phy driver loaded.
>
> It could be that the PHY is strapped to not use its internal RX delay.
> And the PHY has some weird default TX delay, so having the driver
> put some sensible values in is probably better.
It could also be the bootloader putting odd values into the PHY.
Anyway, it will work better with the correct PHY, and enable WoL
support.
Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
Andrew
