Hi Uwe,
Am Montag, 4. März 2024, 09:46:11 CET schrieb Uwe Kleine-König:
> While it requires to have the right phy driver loaded (i.e. motorcomm)
> to make the phy asserting the right delays, this is generally the
> preferred way to define the MAC <-> PHY connection.
>
> Signed-off-by: Uwe Kleine-König <ukleinek@xxxxxxxxxx>
> ---
> Hello,
>
> Andrew already pointed out when I posted the patch introducing the gmac0 node
> that rgmii-id would be the preferred way to setup things. Back then this didn't
> happen because this change broke reception of network packets. However this
> only happend because I didn't have the right phy driver loaded.
trying to understand how the (not) loaded module fits into this :-)
The mdio-bus is supposed to probe the phy and load the appropriate module.
>From your description it sounds like the correct phy module needs to be
actually loaded? Or was that meant to be a "requires to have the right phy
driver compiled" instead?
Heiko
> Best regards
> Uwe
>
> arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> index 6a998166003c..36ad48d46bc1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> @@ -20,15 +20,13 @@ &gmac0 {
> assigned-clock-rates = <0>, <125000000>;
> clock_in_out = "output";
> phy-handle = <&rgmii_phy0>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> pinctrl-names = "default";
> pinctrl-0 = <&gmac0_miim
> &gmac0_tx_bus2
> &gmac0_rx_bus2
> &gmac0_rgmii_clk
> &gmac0_rgmii_bus>;
> - rx_delay = <0x2f>;
> - tx_delay = <0x3c>;
> status = "okay";
> };
>
>
> base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89
>
