On Sun, 2024-03-03 at 12:16 +0000, Jonathan Cameron wrote: > On Fri, 01 Mar 2024 18:14:50 +0100 > Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@xxxxxxxxxx> wrote: > > > From: Nuno Sa <nuno.sa@xxxxxxxxxx> > > > > Use dev_err_probe() in the probe() path. While at it, made some simple > > improvements: > > * Declare a struct device *dev helper. This also makes the style more > > consistent (some places the helper was used and not in other places); > > * Explicitly included the err.h and errno.h headers; > > * Removed an useless else if(); > > * Removed some unnecessary line breaks. > > > > Signed-off-by: Nuno Sa <nuno.sa@xxxxxxxxxx> > > I'd rather see a proposal for dev_errp_probe() than a local solution. > We can fallback to local solution if it doesn't meet with approval! > I was kind of expecting that already :). I'll propose that for device.h. I guess a simple macro should be enough... - Nuno Sá