On 3/03/24 22:48, Geert Uytterhoeven wrote: > Hi Andy, > > On Fri, Mar 1, 2024 at 7:24 PM Andy Shevchenko <andy@xxxxxxxxxx> wrote: >> On Fri, Mar 01, 2024 at 02:42:03PM +1300, Chris Packham wrote: >>> Use the dot on the 7-segment LED block to indicate USB access on the >>> x530. >> As I said, I'm not going to apply this even with Acks. I'll drop this one for the next round. > I guess you should not apply any of the dts patches to the > auxdisplay tree anyway? That's OK by me. I've just been including them so there is an in-tree user of the driver. It also shows how I've been testing things. I can send them via the ARM maintainers once the dust settles on the first two patches. > >> The problem here as I see it is the future decision on how DP should >> behave like. If you put this into DT, we will to support this to the end >> of the platform. > As there exist 7-seg displays (and wirings) with and without DP, > the 7-seg driver and DT bindings should handle both cases. How to > wire/use the DP LED is up to the hardware designer / DTS writer. > > I agree it's a thin boundary between hardware description and software > policy, though. Is that your main concern? In this specific case I'd justify the (ab)use of the DP LED on this product as an optimization so we don't have to find board space for a separate LED to indicate USB activity. I do have an idea for handling the DP for the more general case. Basically if 8 segment GPIOs are supplied we can use a slightly different segment map (map7plus1?) so that characters that are better represented as dots use that instead.
