On 27.02.2024 13:45, Jianhua Lu wrote: > Add usb pd negotiation, but charging is controlled by pm8150b pmic, > so it can only charge battery with 5W, > > Signed-off-by: Jianhua Lu <lujianhua000@xxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > index 6f54f50a70b0..ed103b90f4e6 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi > @@ -636,7 +636,8 @@ &pm8150b_typec { > connector { > compatible = "usb-c-connector"; > > - power-role = "source"; > + op-sink-microwatt = <10000000>; Is 10W really the minimum value for this tablet to function as a sink? Is that what the downstream kernel sets? > + power-role = "dual"; > data-role = "dual"; > self-powered; > > @@ -645,6 +646,12 @@ PDO_FIXED_DUAL_ROLE | > PDO_FIXED_USB_COMM | > PDO_FIXED_DATA_SWAP)>; > > + sink-pdos = <PDO_FIXED(5000, 3000, > + PDO_FIXED_DUAL_ROLE | Please align the PDO_.. against the open brace > + PDO_FIXED_USB_COMM | > + PDO_FIXED_DATA_SWAP) > + PDO_VAR(5000, 12000, 5000)>; 60W max? This is not unheard of, but I'm just making sure you know.. Konrad