On 2/26/24 01:10, Paul Menzel wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
Dear Supreeth,
Thank you for your patch. Should you resent three more nits.
Am 26.02.24 um 07:55 schrieb Andrew Jeffery:
On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote:
This patch adds initial device tree and makefile updates for
AMD Onyx platform.
AMD Onyx platform is an AMD customer reference board with an Aspeed
ast2600 BMC manufactured by AMD.
It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc.
present on AMD Onyx platform.
I’d capitalize I2Cs, UARTs, and MAC, but would write fans.
Thank you. will incorporate in v2.
Also, could you please make the summary a statement by adding a verb in
imperative mood. Maybe:
Add initial device tree for AMD Onyx Platform
Thank you. will incorporate in v2.
I’d also add spaces after the colons in the commit message summary.
[…]
Kind regards,
Paul
