On Fri, Mar 1, 2024 at 12:25 PM Dragan Simic <dsimic@xxxxxxxxxxx> wrote: > > On 2024-03-01 07:17, Dragan Simic wrote: > > On 2024-03-01 06:21, Alexey Charkov wrote: > >> On Fri, Mar 1, 2024 at 1:25 AM Dragan Simic <dsimic@xxxxxxxxxxx> > >> wrote: > >>> On 2024-02-29 20:26, Alexey Charkov wrote: > >>> > This links the PWM fan on Radxa Rock 5B as an active cooling device > >>> > managed automatically by the thermal subsystem, with a target SoC > >>> > temperature of 65C and a minimum-spin interval from 55C to 65C to > >>> > ensure airflow when the system gets warm > >>> > >>> I'd suggest that you replace "automatic active cooling" with "active > >>> cooling" in the patch subject. I know, it may seem like more of the > >>> unnecessary nitpicking, :) but I hope you'll agree that "automatic" > >>> is actually redundant there. It would also make the patch subject > >>> a bit shorter. > >>> > >>> Another option would be to replace "automatic active cooling" with > >>> "automatic fan control", which may actually be a better choice. > >>> I'd be happy with whichever one you prefer. :) > >> > >> Sounds good to me, thanks! > > > > I'm glad that you like it. :) > > > >>> Otherwise, please feel free to add: > >>> > >>> Reviewed-by: Dragan Simic <dsimic@xxxxxxxxxxx> > >> > >> Thank you Dragan, much appreciated! > > > > Thank you for putting up with my nitpicking. :) > > Perhaps the following tag would also be deserved for this patch: > > Helped-by: Dragan Simic <dsimic@xxxxxxxxxxx> > > I hope you agree. :) Definitely! Thanks again for your feedback and contribution! Best regards, Alexey
