On Thu, 29 Feb 2024, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > active-low was lifted to the common schema for leds, but it went > unnoticed that the leds-multicolour binding had "additionalProperties: > false" where the other users had "unevaluatedProperties: false", thereby > disallowing active-low for multicolour leds. Explicitly permit it again. > > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") > Acked-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > --- > > This needs to go via netdev as the commit it fixes (and is based on) > is there > > CC: Pavel Machek <pavel@xxxxxx> > CC: Lee Jones <lee@xxxxxxxxxx> > CC: Rob Herring <robh@xxxxxxxxxx> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > CC: Conor Dooley <conor+dt@xxxxxxxxxx> > CC: Sven Schwermer <sven.schwermer@xxxxxxxxxxxxxxxxxxxxxxxxxxx> > CC: Christian Marangi <ansuelsmth@xxxxxxxxx> > CC: linux-leds@xxxxxxxxxxxxxxx > CC: devicetree@xxxxxxxxxxxxxxx > CC: linux-kernel@xxxxxxxxxxxxxxx > CC: "David S. Miller" <davem@xxxxxxxxxxxxx> > CC: Eric Dumazet <edumazet@xxxxxxxxxx> > CC: Jakub Kicinski <kuba@xxxxxxxxxx> > CC: Paolo Abeni <pabeni@xxxxxxxxxx> > CC: netdev@xxxxxxxxxxxxxxx > --- > Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ > 1 file changed, 2 insertions(+) Please take this via netdev. Acked-by: Lee Jones <lee@xxxxxxxxxx> > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > index 5edfbe347341..a31a202afe5c 100644 > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > @@ -41,6 +41,8 @@ properties: > > pwm-names: true > > + active-low: true > + > color: true > > required: > -- > 2.43.0 > > -- Lee Jones [李琼斯]