On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> It's hard to get the version number for each FEMAC core and it's unknown
> how the version can be used. Remove them until it's really needed.
>
> While at it, remove SoC compatibles and only use fallback compatible.
>
> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> ---
> drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
> index 2406263c9dd3..5a088cba7d4e 100644
> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c
> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
> @@ -945,9 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
> #endif
>
> static const struct of_device_id hisi_femac_match[] = {
> - {.compatible = "hisilicon,hisi-femac-v1",},
> - {.compatible = "hisilicon,hisi-femac-v2",},
> - {.compatible = "hisilicon,hi3516cv300-femac",},
> + {.compatible = "hisilicon,hisi-femac",},
This breaks the ABI. I explained at least twice - use SoC compatibles. ONLY.
Best regards,
Krzysztof
