On 29/02/2024 16:49, Krzysztof Kozlowski wrote: > On 28/02/2024 14:54, Dumitru Ceclan wrote: >> Add support for: AD7172-2, AD7175-8, AD7177-2. >> AD7172-4 does not feature an internal reference, check for external >> reference presence. ... >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml > > There is no such file in next-20240229. > It's not yet accepted https://lore.kernel.org/all/20240228110622.25114-1-mitrutzceclan@xxxxxxxxx/ ... >> + # Model ad7172-4 does not support internal reference >> + # mandatory to have an external reference >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: adi,ad7172-4 >> + then: >> + patternProperties: >> + "^channel@[0-9a-f]$": >> + properties: >> + adi,reference-select: >> + enum: >> + - vref >> + - vref2 >> + - avdd >> + required: >> + - adi,reference-select > > Are you defining properties here? I cannot verify because this file does > not exist in next. > No, just constraining reference-select to be required and exclude "refout-avss". > > > Best regards, > Krzysztof >