On Tue, Feb 27, 2024 at 01:01:41AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH] dt-bindings: firmware: arm,scmi: support system power > > protocol > > > > On Mon, Feb 26, 2024 at 01:28:31PM +0000, Cristian Marussi wrote: > > > On Mon, Feb 26, 2024 at 09:02:43PM +0800, Peng Fan (OSS) wrote: > > > > From: Peng Fan <peng.fan@xxxxxxx> > > > > > > > > Add SCMI System Power Protocol bindings, and the protocol id is 0x12. > > > > > > > Hi, > > > > > > yes this is something I spotted in the past it was missing and I > > > posted a similar patch but I was told that a protocol node without any > > > specific additional properties is already being described by the > > > general protocol node described above. > > Without this patch, there is dtbs_check warning. > > scmi: 'protocol@12' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/firmware/arm,scmi.yaml# > Why are you adding protocol@12 to the device tree ? Does it have a dedicated channel ? If not, you shouldn't need to add it. -- Regards, Sudeep