On Wed, Feb 28, 2024 at 12:28 PM Théo Lebrun <theo.lebrun@xxxxxxxxxxx> wrote: > Previously, drivers/pinctrl/nomadik/pinctrl-nomadik.c registered two > platform drivers: pinctrl & GPIO. Move the GPIO aspect to the > drivers/gpio/ folder, as would be expected. > > Both drivers are intertwined for a reason; pinctrl requires access to > GPIO registers for pinmuxing, pull-disable, disabling interrupts while > setting the muxing and wakeup control. Information sharing is done > through a shared array containing GPIO chips and a few helper > functions. That shared array is not touched from gpio-nomadik when > CONFIG_PINCTRL_NOMADIK is not defined. > > Make no change to the code that moved into gpio-nomadik; there should be > no behavior change following. A few functions are shared and header > comments are added. Checkpatch warnings are addressed. NUM_BANKS is > renamed to NMK_MAX_BANKS. > > It is supported to compile gpio-nomadik without pinctrl-nomadik. The > opposite is not true. > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> Patch applied. It's good to get this move done, then we can iron out minor issues to the GPIO part in the GPIO tree as we move along. I will send the patches to Bartosz with an optional pull request for this immutable branch. Yours, Linus Walleij