On 29/02/2024 06:38, Satya Priya Kakitapalli wrote: > Add device tree bindings for the camera clock controller on > Qualcomm SM8150 platform. > > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx> > --- > .../bindings/clock/qcom,sm8150-camcc.yaml | 77 ++++++++++++ > include/dt-bindings/clock/qcom,sm8150-camcc.h | 135 +++++++++++++++++++++ > 2 files changed, 212 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml > new file mode 100644 > index 000000000000..58c34134ad05 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,sm8150-camcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Camera Clock & Reset Controller on SM8150 > + > +maintainers: > + - Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx> > + > +description: | > + Qualcomm camera clock control module provides the clocks, resets and > + power domains on SM8150. > + > + See also:: include/dt-bindings/clock/qcom,sm8150-camcc.h > + > +properties: > + compatible: > + const: qcom,sm8150-camcc > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: Camera AHB clock from GCC > + - description: Board XO source Do not create your own order of clocks. Open other files and look at the order there. With the order fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof