On 2/28/24 1:45 AM, Simon Horman wrote:
On Tue, Feb 27, 2024 at 10:54:53AM -0800, Justin Chen wrote:There is no advantage of freeing and re-allocating buffers through suspend and resume. This waste cycles and makes suspend/resume time longer. We also open ourselves to failed allocations in systems with heavy memory fragmentation. Signed-off-by: Justin Chen <justin.chen@xxxxxxxxxxxx> Acked-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>...@@ -1118,6 +1083,10 @@ static int bcmasp_open(struct net_device *dev)netif_dbg(intf, ifup, dev, "bcmasp open\n"); + ret = bcmasp_alloc_buffers(intf);+ if (ret) + return ret; +Hi Justin, Do the resources allocated by bcmasp_alloc_buffers() need to be released if an error occurs in bcmasp_open() below this line?
Yes good catch. Will send v3. Thanks, Justin
ret = clk_prepare_enable(intf->parent->clk); if (ret) return ret; -- 2.34.1
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
