On 01/28/2015 03:50 AM, Tomeu Vizoso wrote:
Patches are on its way to add a config file to alsaucm for the Nyan
boards. Use the same card ID that alsaucm will expect.
diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
sound {
- compatible = "nvidia,tegra-audio-max98090-nyan-big",
+ compatible = "nvidia,tegra-audio-max98090-nyan",
"nvidia,tegra-audio-max98090";
I'm not convinced that removing the board-specific compatible value is a
great idea. What if we find we need to distinguish between different
boards that use this same binding in the future. That situation is
exactly why we have board-/SoC-specific values in compatible even if we
don't immediately use them.
- nvidia,model = "Acer Chromebook 13";
+ nvidia,model = "GoogleNyan";
I believe this also technically breaks ABI, since some user-space tools
use the model to look up saved state. Can we not leave this as is, and
just have the UCM files know about both names?
Aside from that, I think the series looks OK at a quick glance.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
