Dear Guenter,
Am 28.02.24 um 10:03 schrieb Guenter Roeck:
On 2/27/24 23:57, Paul Menzel wrote:
Am 27.02.24 um 01:56 schrieb baneric926@xxxxxxxxx:
From: Ban Feng <kcfeng0@xxxxxxxxxxx>
NCT7363Y is an I2C based hardware monitoring chip from Nuvoton.
Please reference the datasheet.
Note that something like
Datasheet: Available from Nuvoton upon request
is quite common for hardware monitoring chips and acceptable.
Yes, it would be nice to document it though. (And finally for vendors to
just make them available for download.)
Could you please give a high level description of the driver design?
Can you be more specific ? I didn't have time yet to look into details,
but at first glance this looks like a standard hardware monitoring driver.
One could argue that the high level design of such drivers is described
in Documentation/hwmon/hwmon-kernel-api.rst.
I don't usually ask for a additional design information for hwmon drivers
unless some chip interaction is unusual and needs to be explained,
and then I prefer to have it explained in the code. Given that, I am
quite curious and would like to understand what you are looking for.
For a 10+ lines commit, in my opinion the commit message should say
something about the implementation. Even it is just, as you wrote, a
note, that it follows the standard design.
Kind regards,
Paul
