On 28/02/24 12:43 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 28/02/2024 07:59, Dharma.B@xxxxxxxxxxxxx wrote:
>>
>>>
>>> I don't know what's this exactly, but if embedded display then maybe
>>> could be part of this device node. If some other display, then maybe you
>>> need another schema, with compatible? But first I would check how others
>>> are doing this.
>>
>> Okay, then I think the driver also needs to be modified, currently the
>> driver parses the phandle and looks for these properties. Also the
>> corresponding dts files.
>
> Driver does not have to be modified in my proposal. You would still have
> phandle.
If I understand correctly, I could define the dt bindings as below
display:
$ref: /schemas/types.yaml#/definitions/phandle
description: A phandle pointing to the display node.
panel:
$ref: panel/panel-common.yaml#
properties:
I will add those properties under panel node and modify the example as below
fb@500000 {
compatible = "atmel,at91sam9g45-lcdc";
reg = <0x00500000 0x1000>;
interrupts = <23 IRQ_TYPE_LEVEL_HIGH 0>;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_fb>;
clocks = <&pmc PMC_TYPE_PERIPHERAL 23>, <&pmc PMC_TYPE_PERIPHERAL
23>;
clock-names = "hclk", "lcdc_clk";
display = <&display>;
display: panel {
bits-per-pixel = <32>;
atmel,lcdcon-backlight;
atmel,dmacon = <0x1>;
atmel,lcdcon2 = <0x80008002>;
atmel,guard-time = <9>;
atmel,lcd-wiring-mode = <1>;
display-timings {
native-mode = <&timing0>;
timing0: timing0 {
clock-frequency = <9000000>;
hactive = <480>;
vactive = <272>;
hback-porch = <1>;
hfront-porch = <1>;
vback-porch = <40>;
vfront-porch = <1>;
hsync-len = <45>;
vsync-len = <1>;
};
};
};
};
This structure is now in sync with the existing DTS files.
>
>
> Best regards,
> Krzysztof
>
--
With Best Regards,
Dharma B.
