Hi Krzysztof, Thank you for the review. On Wed, Feb 28, 2024 at 7:49 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 28/02/2024 00:25, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Add DT binding documentation for System Controller (SYS) found on > > RZ/V2H(P) ("R9A09G057") SoC's. > > > > SYS block contains the SYS_LSI_DEVID register which can be used to > > retrieve SoC version information. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> > > --- > > v1 -> v2 > > - Dropped extal_clk node from example > > - Replaced RZ/V2H{P} -> RZ/V2H(P) > > - Dropped description for clocks & resets properties > > - used <cpg 1> for clocks in example node > > --- > > .../soc/renesas/renesas,r9a09g057-sys.yaml | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > new file mode 100644 > > index 000000000000..72bf8e733dcd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/renesas/renesas,r9a09g057-sys.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas RZ/V2H(P) System Controller (SYS) > > + > > +maintainers: > > + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > + > > +description: > > You need | to preserve formatting > Sure I will add "|". On that note some bindings have "|+" and some "|" what is the preferred one? Cheers, Prabhakar