On Tue, Feb 27, 2024 at 10:25 PM Stefan Wahren <wahrenst@xxxxxxx> wrote:
>
> Hi,
>
> Am 27.02.24 um 17:41 schrieb Andy Shevchenko:
> > On Sun, Feb 04, 2024 at 11:08:51PM +0100, Stefan Wahren wrote:
> > ...
> >
> >> + if (gpiod_cansleep(gpwm->gpio)) {
> >> + return dev_err_probe(dev, -EINVAL,
> >> + "sleeping GPIO %d not supported\n",
> >> + desc_to_gpio(gpwm->gpio));
> > Do not use plain GPIO numbers.
> Uwe already complained this, but i didn't receive a reply on the
> question how do we provide a useful log message (reference to the
> affected GPIO) here? AFAIK the GPIO names are optional.
You have a firmware node path, also you may add a label to GPIO, but
it's unrelated to the message (as it's constant).
%pfw
--
With Best Regards,
Andy Shevchenko
