On 2/26/2024 1:42 AM, Sarosh Hasan wrote: > Updating link clock rate for different speeds is only needed when > using RGMII, as that mode requires changing clock speed when the link > speed changes. Let's restrict updating the link clock speed in > ethqos_update_link_clk() to just RGMII. Other modes such as SGMII > only need to enable the link clock (which is already done in probe). > > Signed-off-by: Sarosh Hasan <quic_sarohasa@xxxxxxxxxxx> Reviewed-by: Abhishek Chauhan <quic_abchauha@xxxxxxxxxxx> > --- > v2 changelog: > - Addressed Konrad Dybcio comment on optimizing the patch > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > index 31631e3f89d0..c182294a6515 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c > @@ -169,6 +169,9 @@ static void rgmii_dump(void *priv) > static void > ethqos_update_link_clk(struct qcom_ethqos *ethqos, unsigned int speed) > { > + if (!phy_interface_mode_is_rgmii(ethqos->phy_mode)) > + return; > + > switch (speed) { > case SPEED_1000: > ethqos->link_clk_rate = RGMII_1000_NOM_CLK_FREQ;