On Sat, Feb 24, 2024 at 04:05:07AM +0800, Yangyu Chen wrote: > The BUILTIN_DTB_SOURCE is only configured for K210 before. Since > SOC_BUILTIN_DTB_DECLARE is removed at commit d5805af9fe9f ("riscv: Fix > builtin DTB handling") from patch [1], the kernel cannot choose one of the > dtbs from then on and always take the first one dtb to use. Then, another > commit 0ddd7eaffa64 ("riscv: Fix BUILTIN_DTB for sifive and microchip soc") > from patch [2] supports BUILTIN_DTB_SOURCE for other SoCs. However, this > feature will only work if the Kconfig we use links the dtb we expected in > the first place as mentioned in the thread [3]. Thus, a config > BUILTIN_DTB_SOURCE is needed for all SoCs to choose one dtb to use. > > For some considerations, this patch also removes default y if XIP_KERNEL > for BUILTIN_DTB, as this requires setting a proper dtb to use on the > BUILTIN_DTB_SOURCE, else the kernel with XIP but does not set > BUILTIN_DTB_SOURCE or unselect BUILTIN_DTB will not boot. > > Also, this patch removes the default dtb string for k210 from Kconfig to > nommu_k210_defconfig and nommu_k210_sdcard_defconfig to avoid complex > Kconfig settings for other SoCs in the future. > > Changes since v1: > - remove default y for BULTIN_DTB in any cases > - remove default DTB_SOURCE for k210 and moved to its defconfig file > - remove building dtb object file for other SoCs > - reword help message to say N if unsure for BUILTIN_DTB_SOURCE > - reword commit message > - v1: https://lore.kernel.org/linux-riscv/tencent_AB625442CC1BCFF86E04D7B5891C43719109@xxxxxx/ This section here (the changelog) should be below the --- line so that it does not get into the commit history. Otherwise Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature