Hi Adam, On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@xxxxxxxxx> wrote: > Update the binding to add support for various Renesas SoC's with PowerVR > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > the table to indicate such like what was done for the ti,am62-gpu. > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -14,6 +14,11 @@ properties: > compatible: > items: > - enum: > + - renesas,r8a774a1-gpu I would add a comment like this: - renesas,r8a774a1-gpu # PowerVR Series 6XT GX6650 on RZ/G2M > + - renesas,r8a774e1-gpu .. # PowerVR Series 6XT GX6650 on RZ/G2H > + - renesas,r8a77951-gpu ... # PowerVR Series 6XT GX6650 on R-Car H3 ES2.0+ > + - renesas,r8a77960-gpu ... # PowerVR Series 6XT GX6250 on R-Car M3-W > + - renesas,r8a77961-gpu ... # PowerVR Series 6XT GX6250 on R-Car M3-W+ > - ti,am62-gpu > - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable > > @@ -51,7 +56,13 @@ allOf: > properties: > compatible: > contains: > - const: ti,am62-gpu > + enum: > + - ti,am62-gpu > + - renesas,r8a774a1-gpu > + - renesas,r8a774e1-gpu > + - renesas,r8a77951-gpu > + - renesas,r8a77960-gpu > + - renesas,r8a77961-gpu Please preserve alphabetical sort order. > then: > properties: > clocks: > -- > 2.43.0 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds