On Mon, Feb 26, 2024 at 11:11:23PM +0200, Dmitry Baryshkov wrote:
> Add required-opps property to the display clock controller. This makes
> it cast minimal vote on the MMCX lane to prevents resets caused by the
> DisplayPort / panel probing.
>
Interesting wording, this is exactly what e3e56c050ab6 ("soc: qcom:
rpmhpd: Make power_on actually enable the domain") was supposed to do
(cast minimal enabled vote).
And sure enough, there's a bug in my patch:
https://lore.kernel.org/linux-arm-msm/20240226-rpmhpd-enable-corner-fix-v1-1-68c004cec48c@xxxxxxxxxxx/T/#u
Regards,
Bjorn
> Fixes: 57d6ef683a15 ("arm64: dts: qcom: sc8280xp: Define some of the display blocks")
> Cc: Johan Hovold <johan+linaro@xxxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index febf28356ff8..ec85c81f65cd 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -3938,6 +3938,7 @@ dispcc0: clock-controller@af00000 {
> <0>,
> <0>;
> power-domains = <&rpmhpd SC8280XP_MMCX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
>
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> @@ -5034,6 +5035,7 @@ dispcc1: clock-controller@22100000 {
> <0>,
> <0>;
> power-domains = <&rpmhpd SC8280XP_MMCX>;
> + required-opps = <&rpmhpd_opp_low_svs>;
>
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> --
> 2.39.2
>
