Hi Andy, On Mon, Feb 19, 2024 at 6:03 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > Add initial device tree documentation for Maxim MAX6958/6959. > As per reviewer's request mention the fact of absence reset and > power enable pins, since the hardware is quite simple. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/auxdisplay/maxim,max6959.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/auxdisplay/maxim,max6959.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX6958/6959 7-segment LED display controller > + > +maintainers: > + - Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > + > +description: > + The Maxim MAX6958/6959 7-segment LED display controller provides > + an I2C interface to up to four 7-segment LED digits. The MAX6959, > + in comparison to MAX6958, adds input support. Type of the chip can > + be autodetected via specific register read, and hence the features > + may be enabled in the driver at run-time, in case they are requested > + via Device Tree. A given hardware is simple and does not provide > + any additional pins, such as reset or enable. > + > +properties: > + compatible: > + const: maxim,max6959 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg To handle cases where less than 4 characters are wired (based on hit,hd44780.yaml): display-width-chars: description: Width of the display, in character cells. minimum: 1 maximum: 4 default: 4 The rest LGTM, so Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
