Hi Andy,
On Mon, Feb 19, 2024 at 6:03 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> For better usability group the display drivers together in Kconfig
> and Makefile. With this we will have the following sections:
> - Character LCD
> - Samsung KS0108 LCD controller
> - Single character line display
> - Character LCD with non-conforming interface
>
> While at it, drop redundant 'default n' entries.
>
> Tested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> +#
> +# Single character line display section
> +#
> +config LINEDISP
> + tristate "Character line display core support" if COMPILE_TEST
> + help
> + This is the core support for single-line character displays, to be
> + selected by drivers that use it.
> +
> +config IMG_ASCII_LCD
> + tristate "Imagination Technologies ASCII LCD Display"
> + depends on HAS_IOMEM
> + default y if MIPS_MALTA
> + select MFD_SYSCON
> + select LINEDISP
> + help
> + Enable this to support the simple ASCII LCD displays found on
> + development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
> + from Imagination Technologies.
> +
> +config HT16K33
> + tristate "Holtek Ht16K33 LED controller with keyscan"
HT16K33 also supports dot-matrix displays using fbdev...
Yes, categorizing is difficult.
> --- a/drivers/auxdisplay/Makefile
> +++ b/drivers/auxdisplay/Makefile
> @@ -5,12 +5,15 @@
>
> obj-$(CONFIG_CHARLCD) += charlcd.o
> obj-$(CONFIG_HD44780_COMMON) += hd44780_common.o
> -obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
> +obj-$(CONFIG_HD44780) += hd44780.o
> +obj-$(CONFIG_LCD2S) += lcd2s.o
> +obj-$(CONFIG_PARPORT_PANEL) += panel.o
> +
> obj-$(CONFIG_KS0108) += ks0108.o
> obj-$(CONFIG_CFAG12864B) += cfag12864b.o cfag12864bfb.o
> -obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> -obj-$(CONFIG_HD44780) += hd44780.o
> -obj-$(CONFIG_HT16K33) += ht16k33.o
> -obj-$(CONFIG_PARPORT_PANEL) += panel.o
> -obj-$(CONFIG_LCD2S) += lcd2s.o
> +
> obj-$(CONFIG_LINEDISP) += line-display.o
> +obj-$(CONFIG_IMG_ASCII_LCD) += img-ascii-lcd.o
> +obj-$(CONFIG_HT16K33) += ht16k33.o
> +
> +obj-$(CONFIG_ARM_CHARLCD) += arm-charlcd.o
I still think these should be sorted alphabetically.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
