On 24-02-26, Krzysztof Kozlowski wrote: > On 21/02/2024 18:43, Marco Felsch wrote: > > Make use of the common spi-peripheral-props.yaml to pull in the common > > spi device properties and limit the spi-max-frequency to 10 MHz as this > > is the max. frequency if VDDIO >= 1.62V. > > The example uses i2c, so I would expect to see in commit msg explanation > which devices are SPI devices. All listed devices can either operate in I2C or in SPI mode. > Also: > A nit, subject: drop second/last, redundant "binding". The "dt-bindings" > prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Will rephrase it if you want me to update the commit message. Regards, Marco > > > > Best regards, > Krzysztof > >