Le 26/02/2024 à 09:09, Krzysztof Kozlowski a écrit :
On 26/02/2024 08:38, Raphaël Gallais-Pou wrote:
+
+allOf:
+ - $ref: serial.yaml#
+
+properties:
+ compatible:
+ const: st,asc
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
This wasn't here before and your commit msg does not explain it.
Looking at the device-tree I found that every instance of this device
refers to a phandle of a clock.
Moreover in the driver of the device, the probe fails if it does not
find a clock, hence this addition.
cf. drivers/tty/serial/st-asc.c:701
Commit msg should explain differences from pure conversion and the
reason behind. Otherwise how can we know why you did it?
Indeed, I will change the commit log.
Regards,
Raphaël
Best regards,
Krzysztof
