Hi Krzysztof, > On 23/02/2024 09:17, Gabor Juhos wrote: <snip> >> --- >> Note: running 'make CHECK_DTBS=y qcom/ipq5018-tplink-archer-ax55-v1.dtb' >> shows the following: >> >> DTC_CHK arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb >> <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short >> from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# >> <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short >> from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# >> <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupts: [[0, 62, 4]] is too short >> from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# >> <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names:0: 'pwr_event' was expected >> from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# >> <...>/arch/arm64/boot/dts/qcom/ipq5018-tplink-archer-ax55-v1.dtb: usb@8af8800: interrupt-names: ['hs_phy_irq'] is too short >> from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# >> >> This is not caused by the new device tree per se but comes from >> the usb@8af8800 node defined in ipq5018.dtsi. Running the check >> on 'qcom/ipq5018-rdp432-c2.dtb' shows the same. > > Thanks for noticing and describing. Appreciated! FWIW, I have checked that in the meantime. The warning happens since commit 53c6d854be4e ("dt-bindings: usb: dwc3: Clean up hs_phy_irq in binding"). Reverting that eliminates the warning. > >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> .../dts/qcom/ipq5018-tplink-archer-ax55-v1.dts | 133 +++++++++++++++++++++ >> 2 files changed, 134 insertions(+) > > ... <snip> >> + >> +&tlmm { >> + button_pins: button-pins-state { >> + pins = "gpio25", "gpio31"; >> + bias-pull-up; >> + drive-strength = <8>; >> + function = "gpio"; > > Usually we keep 'function' as second property, after 'pins', but there > is no need to send new version just for that. Sorry, it is my fault. I should have noticed that pattern based on the other dts files. Nevertheless, I can send a v2 or a follow-up patch to fix the ordering so we can avoid having a bad example in the tree. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Thank you for the review! Regards, Gabor
