On 23/02/2024 22:43, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> Document the DWC3 controller used by Hi3798MV200.
>
> Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: hisilicon,hi3798mv200-dwc3
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 1
> +
> + reg: true
Constraints. maxItems: X
> +
> + ranges: true
> +
> + clocks:
> + items:
> + - description: Controller bus clock
> + - description: Controller suspend clock
> + - description: Controller reference clock
> + - description: Controller gm clock
> + - description: Controller gs clock
> + - description: Controller utmi clock
> + - description: Controller pipe clock
> +
> + clock-names:
> + items:
> + - const: bus
> + - const: suspend
> + - const: ref
> + - const: gm
> + - const: gs
> + - const: utmi
> + - const: pipe
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + const: soft
> +
> +patternProperties:
> + '^usb@[0-9a-z]+$':
unit addresses are in hex, so a-f
Open existing bindings and look how it is done there. There are no
bindings for DWC3 glue/wrapper device having a-z.
> + $ref: snps,dwc3.yaml#
> +
> +additionalProperties: false
Same comments: open existing bindings and take a look how it is there.
This goes after 'required:' block.
> +
> +required:
> + - compatible
> + - '#address-cells'
> + - '#size-cells'
> + - ranges
> + - reg
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + usb@98a0000 {
> + compatible = "hisilicon,hi3798mv200-dwc3";
reg is always the second property. ranges is third.
> + #address-cells = <1>;
> + #size-cells = <1>;
Use 4 spaces for example indentation.
Best regards,
Krzysztof
