On Fri, Feb 23, 2024 at 10:10:47PM +0100, Konrad Dybcio wrote:
> On 23.02.2024 00:16, Elliot Berman wrote:
> > Add driver to detect when running under Gunyah. It performs basic
> > identification hypercall and populates the platform bus for resource
> > manager to probe.
> >
> > Signed-off-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>
> > ---
>
> [...]
>
> > +
> > + /* Might move this out to individual drivers if there's ever an API version bump */
> > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) {
> > + pr_info("Unsupported Gunyah version: %u\n",
> > + gunyah_api_version(&gunyah_api));
>
> Weird for this not to be an error, but it's probably not worth resending
> over if it's the only thing
It is an error, but maybe I misunderstood:
> > + /* Might move this out to individual drivers if there's ever an API version bump */
> > + if (gunyah_api_version(&gunyah_api) != GUNYAH_API_V1) {
> > + pr_info("Unsupported Gunyah version: %u\n",
> > + gunyah_api_version(&gunyah_api));
> > + return -ENODEV;
> > + }
