Hi Geert,
Thanks for your feedback.
On 2024-02-15 17:03:33 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Tue, Nov 21, 2023 at 7:38 PM Niklas Söderlund
> <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> > Add bindings for Renesas R-Car Ethernet TSN End-station IP. The RTSN
> > device provides Ethernet network.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
>
> Thanks for your patch, which is now commit c5b9f4792ea6b9ab
> ("dt-bindings: net: renesas,ethertsn: Add Ethernet TSN") in v6.8-rc1.
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/renesas,ethertsn.yaml
>
> > + interrupts:
> > + items:
> > + - description: TX data interrupt
> > + - description: RX data interrupt
> > +
> > + interrupt-names:
> > + items:
> > + - const: tx
> > + - const: rx
>
> What about the (17!) other interrupts?
I did consider them but compared to say ravb each rtsn interrupt have a
rather lose description and no easy to define name. So I reasoned it was
better to only name the ones we use as we can give them sane names and
then as the driver grows with features we can extend the binding.
As each interrupt have a name this would not cause any backward
compatibility issues right?
>
> > + rx-internal-delay-ps:
> > + enum: [0, 1800]
> > +
> > + tx-internal-delay-ps:
> > + enum: [0, 2000]
>
> These two should either have a default, or be required (like on
> EtherAVB, where we couldn't have a default because the absence of
> these properties is used to enable a legacy fallback).
This is a good point, I have sent a patch to address this by adding a
default value.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Kind Regards,
Niklas Söderlund
