On Fri, Feb 23, 2024 at 3:38 PM Dumitru Ceclan <mitrutzceclan@xxxxxxxxx> wrote: > > Add optional irq_num attribute to ad_sigma_delta_info structure for > selecting the used interrupt line for ADC's conversion completion. ... > * @data_reg: Address of the data register, if 0 the default address of 0x3 will > * be used. > * @irq_flags: flags for the interrupt used by the triggered buffer > + * @irq_line: IRQ for reading conversions. If 0, spi->irq will be used > * @num_slots: Number of sequencer slots Now kernel doc order is unaligned with the real member order. Moreover, have you checked with `pahole`? > struct ad_sigma_delta_info { > @@ -60,6 +61,7 @@ struct ad_sigma_delta_info { > unsigned int data_reg; > unsigned long irq_flags; > unsigned int num_slots; > + int irq_line; > }; But no need to resend, it's minor and Jonathan can probably amend this whilst applying. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko