On Fri, Feb 02, 2024 at 02:34:39PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > Add i.MX SCMI Extension protocol BBM and MISC binding. > Hi, just a few remarks down below only about the SCMI related stuff... > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../devicetree/bindings/firmware/nxp,scmi.yaml | 64 ++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml > new file mode 100644 > index 000000000000..00d6361bbbea > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/nxp,scmi.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/nxp,scmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX System Control and Management Interface (SCMI) Protocol Extension > + ... (SCMI) Vendor Protocols > +maintainers: > + - Peng Fan <peng.fan@xxxxxxx> > + > +allOf: > + - $ref: arm,scmi.yaml# > + > +properties: > + protocol@11: protocol@81 ? > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x81 > + > + protocol@13: protocol@84 ? > + $ref: 'arm,scmi.yaml#/$defs/protocol-node' > + unevaluatedProperties: false > + > + properties: > + reg: > + const: 0x84 > + > + wakeup-sources: > + description: each entry consists of 2 integers and represents the source and edge > + items: > + items: > + - description: the wakeup source > + - description: the wakeup edge > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > + > +additionalProperties: false > + > +examples: > + - | > + firmware { > + scmi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + protocol@81 { > + reg = <0x81>; > + }; > + > + protocol@84 { > + reg = <0x84>; > + wakeup-sources = <6 1 > + 7 1 > + 8 1 > + 9 1 > + 10 1>; > + }; > + }; > + }; > +... > Thanks, Cristian
