On 23.02.2024 11:45, Biju Das wrote: >> On 27.01.2024 17:17, Anup Patel wrote: >>> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >>> >>> Now that the GIC-v3 callback can handle invocation with a fwspec >>> parameter count of 0 lift the restriction in the core code and invoke >>> select() unconditionally when the domain provides it. >>> >>> Preparatory change for per device MSI domains. >>> >>> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >>> Signed-off-by: Anup Patel <apatel@xxxxxxxxxxxxxxxx> >> >> This patch landed recently in linux-next (next-20240221) as commit >> de1ff306dcf4 ("genirq/irqdomain: Remove the param count restriction from >> select()"). I've noticed that it breaks booting of Qualcomm's Robotics >> RB5 ARM64 board (arch/arm64/boot/dts/qcom/qrb5165-rb5.dts). Booting >> freezes after "clk: Disabling unused clocks", but this is probably a >> consequence of some earlier failure. Reverting $subject on top of >> next-20240221 fixes this problem. Let me know how can I help debugging >> this issue. >> >> >>> --- >>> kernel/irq/irqdomain.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index >>> 0bdef4fe925b..8fee37918195 100644 >>> --- a/kernel/irq/irqdomain.c >>> +++ b/kernel/irq/irqdomain.c >>> @@ -448,7 +448,7 @@ struct irq_domain *irq_find_matching_fwspec(struct >> irq_fwspec *fwspec, >>> */ >>> mutex_lock(&irq_domain_mutex); >>> list_for_each_entry(h, &irq_domain_list, link) { >>> - if (h->ops->select && fwspec->param_count) >>> + if (h->ops->select) >>> rc = h->ops->select(h, fwspec, bus_token); >>> else if (h->ops->match) >>> rc = h->ops->match(h, to_of_node(fwnode), bus_token); > This patch looks reverted on todays's next. But there was a fix for fixing the issue you mentioned [1] > > [1] https://lore.kernel.org/all/170844679345.398.17551290253758129895.tip-bot2@tip-bot2/ Thanks! Today's next seems to be broken on ARM64 (doesn't compile here), so I've missed it. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland