On Tue, 20 Feb 2024, Bartosz Golaszewski wrote: > On Mon, Feb 19, 2024 at 9:23 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > The ChromeOS embedded controller (EC) supports setting the state of > > GPIOs when the system is unlocked, and getting the state of GPIOs in all > > cases. The GPIOs are on the EC itself, so the EC acts similar to a GPIO > > expander. Add the #gpio-cells and gpio-controller properties to the > > cros-ec binding so that other devices described in DT can get the GPIOs > > on the EC. > > > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > > Cc: Bartosz Golaszewski <brgl@xxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > > Cc: Conor Dooley <conor+dt@xxxxxxxxxx> > > Cc: Lee Jones <lee@xxxxxxxxxx> > > Cc: Benson Leung <bleung@xxxxxxxxxxxx> > > Cc: Guenter Roeck <groeck@xxxxxxxxxxxx> > > Cc: <devicetree@xxxxxxxxxxxxxxx> > > Cc: <chrome-platform@xxxxxxxxxxxxxxx> > > Cc: Pin-yen Lin <treapking@xxxxxxxxxxxx> > > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > index e1ca4f297c6d..aac8819bd00b 100644 > > --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > @@ -93,6 +93,11 @@ properties: > > '#size-cells': > > const: 0 > > > > + '#gpio-cells': > > + const: 2 > > + > > + gpio-controller: true > > + > > typec: > > $ref: /schemas/chrome/google,cros-ec-typec.yaml# > > > > @@ -275,6 +280,8 @@ examples: > > interrupts = <99 0>; > > interrupt-parent = <&gpio7>; > > spi-max-frequency = <5000000>; > > + #gpio-cells = <2>; > > + gpio-controller; > > > > proximity { > > compatible = "google,cros-ec-mkbp-proximity"; > > -- > > https://chromeos.dev > > > > Applied, thanks! Why are you applying this MFD patch? -- Lee Jones [李琼斯]