On Thu, Feb 22, 2024 at 01:07:42PM +0200, Dumitru Ceclan wrote: > Add optional irq_num attribute to ad_sigma_delta_info structure for > selecting the used interrupt line for adc's conversion completion. ADC's ... > + * @irq_num: IRQ for reading conversions. If 0, spi->irq will be used Naming is a bit confusing. Does _num mean the amount of IRQ vectors? Perhaps irq_line, irq_conv? ... > + unsigned long irq_num; Why is it not simple (signed) int? ... > + unsigned int irq_num; Ditto. -- With Best Regards, Andy Shevchenko