On 2/21/2024 8:03 PM, Krzysztof Kozlowski wrote:
On 21/02/2024 15:31, Konrad Dybcio wrote:
On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
On 21/02/2024 15:04, root wrote:
From: Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx>
Add global interrupt support in dt-bindings for SA8775p RC platform.
What is this global interrupt? Why wasn't it there before?
Signed-off-by: Mrinmay Sarkar <quic_msarkar@xxxxxxxxxxx>
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 26 +++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index a93ab3b54066..d86fb63a2d2c 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -63,7 +63,7 @@ properties:
interrupt-names:
minItems: 1
- maxItems: 8
+ maxItems: 9
iommu-map:
minItems: 1
@@ -873,8 +873,30 @@ allOf:
compatible:
contains:
enum:
- - qcom,pcie-msm8996
- qcom,pcie-sa8775p
+ then:
+ oneOf:
No need, drop.
Moreover, I think this global irq should be present on all qc platforms
Heh, this will anyway conflict with my series:
https://lore.kernel.org/all/90a50ab4-a513-48af-b13a-bba082e49540@xxxxxxxxxx/
https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@xxxxxxxxxx/
Thanks for sharing the series. will make change top of your series on v2.
Thanks,
Mrinmay
Best regards,
Krzysztof
