On Wed, Feb 21, 2024 at 5:43 AM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote: > > On 19/02/2024 16:36, Andre Przywara wrote: > > Hi, > > > > this is v5 of this series originally by Martin, only some cosmetic > > changes this time, for instance mentioning experiments with the SRAM > > controller registers to confirm that it's not an SRAM region which fixes > > the temperature reporting issue. > > See the Changelog below for more details. > > ================== > > > > This series introduces support for the thermal sensors in the Allwinner > > H616 SoCs, which includes its siblings H618 and T507. The actual > > temperature reading turns out to be very similar to the H6 SoC, just > > with support for two more sensors. One nasty complication is caused > > by reports about temperatures above 200C, which are related to the > > firmware being run (because the vendor U-Boot contains a hack avoiding > > this problem). Some investigation and digging in BSP code later > > we identified that bit 16 in register 0x3000000 (SYS_CFG) needs to be > > cleared for the raw temperature register values to contain reasonable > > values. > > To achieve this, patch 1/7 exports this very register from the already > > existing SRAM/syscon device. Patch 5/7 then adds code to the thermal > > driver to find that device via a new DT property, and query its regmap > > to clear bit 16 in there. > > Patch 4/7 reworks the existing H6 calibration function to become > > compatible with the H616, many thanks to Maksim for figuring this out. > > This makes the actual enablement patch 6/7 very easy. > > > > The rest of the patches are straightforward and build on Martin's > > original work, with some simplifications, resulting in more code sharing. > > > > Please have a look! > > Thanks for the detailed explanation. > > I'm willing to pick the patches 1-6 and let the last one to go through > the allwinner tree. > > However I need the blessing from the different designed maintainers for > the thermal driver and from the sunxi_sram For sun8i_thermal: Acked-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx> > Thanks > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog >
