On 24-02-21 15:41:41, Konrad Dybcio wrote: > On 21.02.2024 15:38, Abel Vesa wrote: > > Add nodes for SMB2360 with the eUSB2 repeater nodes. > > > > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/smb2360.dtsi | 51 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/smb2360.dtsi b/arch/arm64/boot/dts/qcom/smb2360.dtsi > > new file mode 100644 > > index 000000000000..8d7bdb56e6fe > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/smb2360.dtsi > > @@ -0,0 +1,51 @@ > > +// SPDX-License-Identifier: BSD-3-Clause > > +/* > > + * Copyright (c) 2023, Linaro Limited > > + */ > > + > > +#include <dt-bindings/interrupt-controller/irq.h> > > +#include <dt-bindings/spmi/spmi.h> > > + > > +/ { > > +}; > > + > > +&spmi_bus1 { > > + smb2360h: pmic@7 { > > Hm, I'm not 100% sure about bringing in this letter-suffix notation.. > > But then, is there anything better? What are they called in schematics? > SMB2360_n, perhaps? Yeah, just realized that this is wrong. I need to do something like sc8280xp-pmics.dtsi. There are different sources of information for the suffix, some of them use smb2360k, some of them use smb2360_0. Will go with the second. > > konrad