On 2/21/2024 4:12 PM, Krzysztof Kozlowski wrote:
On 19/02/2024 20:57, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
Also mark the clock optional
Why? Your commit msg must provide rationale. Clocks are rarely optional
signals, so this looks wrong.
Well. I don't know too much about the hardware either. I think the clock
can be either shared with MAC controller or completely non-existent in
hardware.
But from the driver side, the clock must be stripped from MDIO bus node.
The clocks must be controlled entirely within MAC controller driver. Do
I need to mention it in this commit too?
Actually I've never seen anything like "MDIO bus clock" in the
datasheet. The MDIO bus and MAC controller are activated simultaneously.
So I think removing this clock entirely is also acceptable.
Best regards,
Krzysztof
--
Regards,
Yang Xiwen
