On 2/20/24 17:37, Vladimir Oltean wrote: > On Tue, Feb 20, 2024 at 02:12:52PM -0500, Sean Anderson wrote: >> On 2/20/24 09:50, Vladimir Oltean wrote: >> > Notice that unlike fm1-mac10 (node "ethernet@f2000"), there is no >> > pcs-handle-names property (fm1-mac10 has it defined in fsl-ls1046-post.dtsi, >> > whereas fm1-mac9 doesn't. Don't ask me why, I don't know....) >> >> I think this is just because this ethernet is always XFI and never (Q)SGMII. > > Is that so? With SerDes protocol 0x3333, won't the PCS that's connected > to fm1-mac9 use SGMII/1000BASE-X (thus not 10GBASE-R)? Yeah, so I guess it just can't be QSGMII. > And as for QSGMII, what's the relevance of that? You can't have one > device tree good for all SerDes protocols and RCW pinmuxing options. The goal is for the "generic" includes to be generic. So the board-specific stuff lives in the board-specific device tree source. And the only thing board-specific is the phy interface, since the drivers can figure out the rest. > Either there are 4 MACs aggregated onto a single lane, or there is one > MAC per lane, but I've never encountered any use case for alternating > between these 2 configurations at runtime, or with same device tree for > that matter, have you? QSGMII seems to have been the original motivation > for listing all possible PCSes of a MAC in pcs-handle-names, but again, why? With SGMII and XFI, the PCS sits on the MAC's MDIO bus. So for SGMII and XFI if we don't have any labels we can just assume the PCS handle is for the right PCS. But for QSGMII the PCSs sit on another MAC's MDIO bus. So we need to tell the MAC where to find the PCS. This means we need to supply multiple PCSs to the MAC, and thus we need names to differentiate them. Since MAC9 doesn't have QSGMII, I suppose I never bothered to add names. --Sean [Embedded World 2024, SECO SpA]<https://www.messe-ticket.de/Nuernberg/embeddedworld2024/Register/ew24517689>
