Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/19/24 14:18, Chris Packham wrote:
From: Ibrahim Tilki <Ibrahim.Tilki@xxxxxxxxxx>

Adding support for Analog Devices MAX313XX series RTCs.


Adding -> Add

The subject should really be something like "rtc: max31335: Add support
for additional chips", with details in the patch description.

All those (in my opinion unnecessary) function, data structure,
and variable renames makes it really difficult to review the code.
I don't see the point of that, so please don't expect any further
feedback about the hwmon changes from me.

Thanks,
Guenter





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux